Wk03 Learning Journal: HW 1 Code Review
I worked with Stan and Ysabelle. We shared our code and gave each other feedback.
Feedback I gave:
Stan’s code was efficient. I suggested simplifying chooseWord() and organizing constructors better.
Ysabelle’s code was readable with clear variable names. I recommended improving how she selects unused words.
Feedback I received:
Stan said my chooseWord() should return early if all words are used, and suggested using List<Character> for guessed letters.
Ysabelle liked my comments and variable names, but noted I didn’t print the guessed word in displayGameState() and had some leftover TODOs.
Trends:
Everyone struggled with displayGameState() passing the test and leaving TODOs.
Reflections:
-
I’ll clean up comments and improve
chooseWord() -
displayGameState()test was the hardest -
Tests work but could use better messages
-
They cover most main features
-
I’d add hints for each test
-
I struggled with test formatting
-
Stan struggled with the same test
-
File reading was easy
-
Biggest win: all tests passed without edits
Comments
Post a Comment